tbaeder added a comment. So, if I understand the code correctly, we call `CheckEvaluationResult` with `SubObjectDecl=nullptr` when we're not checking an actual field but just an array/record, so we can't run into this problem anyway, so the assert seems fine.
I don't fully understand the problem with the `gnu::weak` stuff, in any case, adding it to this patch seems wrong. https://godbolt.org/z/qn997n85n //does// emit a note, but it's not the one this patch is about, so is that even relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
