This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4edc2c9fa35: Constexpr evaluator should treat [[gnu::weak]] member pointer comparisons as… (authored by hazohelet, committed by aaron.ballman).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148419/new/ https://reviews.llvm.org/D148419 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/crash-lambda-weak-attr.cpp Index: clang/test/SemaCXX/crash-lambda-weak-attr.cpp =================================================================== --- /dev/null +++ clang/test/SemaCXX/crash-lambda-weak-attr.cpp @@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +struct Weak { + [[gnu::weak]]void weak_method(); +}; +static_assert([](){ return &Weak::weak_method != nullptr; }()); // expected-error {{static assertion expression is not an integral constant expression}} \ + // expected-note {{comparison against pointer to weak member 'Weak::weak_method' can only be performed at runtime}} \ + // expected-note {{in call to}} + Index: clang/lib/AST/ExprConstant.cpp =================================================================== --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -13142,12 +13142,12 @@ if (LHSValue.getDecl() && LHSValue.getDecl()->isWeak()) { Info.FFDiag(E, diag::note_constexpr_mem_pointer_weak_comparison) << LHSValue.getDecl(); - return true; + return false; } if (RHSValue.getDecl() && RHSValue.getDecl()->isWeak()) { Info.FFDiag(E, diag::note_constexpr_mem_pointer_weak_comparison) << RHSValue.getDecl(); - return true; + return false; } // C++11 [expr.eq]p2: Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -312,6 +312,8 @@ (`#61417 <https://github.com/llvm/llvm-project/issues/61417>`_) - Fix crash after suggesting typo correction to constexpr if condition. (`#61885 <https://github.com/llvm/llvm-project/issues/61885>`_) +- Clang constexpr evaluator now treats comparison of [[gnu::weak]]-attributed + member pointer as an invalid expression. Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Index: clang/test/SemaCXX/crash-lambda-weak-attr.cpp =================================================================== --- /dev/null +++ clang/test/SemaCXX/crash-lambda-weak-attr.cpp @@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +struct Weak { + [[gnu::weak]]void weak_method(); +}; +static_assert([](){ return &Weak::weak_method != nullptr; }()); // expected-error {{static assertion expression is not an integral constant expression}} \ + // expected-note {{comparison against pointer to weak member 'Weak::weak_method' can only be performed at runtime}} \ + // expected-note {{in call to}} + Index: clang/lib/AST/ExprConstant.cpp =================================================================== --- clang/lib/AST/ExprConstant.cpp +++ clang/lib/AST/ExprConstant.cpp @@ -13142,12 +13142,12 @@ if (LHSValue.getDecl() && LHSValue.getDecl()->isWeak()) { Info.FFDiag(E, diag::note_constexpr_mem_pointer_weak_comparison) << LHSValue.getDecl(); - return true; + return false; } if (RHSValue.getDecl() && RHSValue.getDecl()->isWeak()) { Info.FFDiag(E, diag::note_constexpr_mem_pointer_weak_comparison) << RHSValue.getDecl(); - return true; + return false; } // C++11 [expr.eq]p2: Index: clang/docs/ReleaseNotes.rst =================================================================== --- clang/docs/ReleaseNotes.rst +++ clang/docs/ReleaseNotes.rst @@ -312,6 +312,8 @@ (`#61417 <https://github.com/llvm/llvm-project/issues/61417>`_) - Fix crash after suggesting typo correction to constexpr if condition. (`#61885 <https://github.com/llvm/llvm-project/issues/61885>`_) +- Clang constexpr evaluator now treats comparison of [[gnu::weak]]-attributed + member pointer as an invalid expression. Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits