kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
================
Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:398
+ )cpp",
+ {include_cleaner::Header{"bar.h"}, include_cleaner::Header{"foo.h"}},
+ include_cleaner::Header{"bar.h"}},
----------------
can you add a similar test case in which `foo.h` comes before `bar.h` ?
================
Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:410
+ TestTU TU;
+ TU.Filename = "foo.cpp";
+ TU.Code = Code.code();
----------------
nit: no need for the filename
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147044/new/
https://reviews.llvm.org/D147044
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
