xen0n added inline comments.
================ Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ ---------------- SixWeining wrote: > Better to use “loongarch64” when talking about debian? Refer > https://wiki.debian.org/Multiarch/Tuples It's the dpkg arch identifier and actually [[ https://wiki.debian.org/Ports/loong64 | the port's official name ]]. I chose it because it's shorter. Do we still want to emphasize the target tuple instead of the distro identity in this case? ================ Comment at: clang/test/Driver/linux-header-search.cpp:252 +// RUN: --gcc-toolchain="" \ +// RUN: | FileCheck --check-prefix=CHECK-LOONG64-GNU %s +// ---------------- SixWeining wrote: > Use LA64 instead of LOONG64? Similarly I meant to refer to the Debian port name here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm.org/D142688 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
