This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG271a73dae32f: [dataflow] HTMLLogger: fix off-by-one in the BB listing (authored by sammccall).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148951/new/ https://reviews.llvm.org/D148951 Files: clang/lib/Analysis/FlowSensitive/HTMLLogger.html Index: clang/lib/Analysis/FlowSensitive/HTMLLogger.html =================================================================== --- clang/lib/Analysis/FlowSensitive/HTMLLogger.html +++ clang/lib/Analysis/FlowSensitive/HTMLLogger.html @@ -35,9 +35,15 @@ </template> </div> <table id="bb-elements"> +<template> + <tr id="{{selection.bb}}.0"> + <td class="{{selection.bb}}">{{selection.bb}}.0</td> + <td>(initial state)</td> + </tr> +</template> <template data-for="elt in cfg[selection.bb].elements"> - <tr id="{{selection.bb}}.{{elt_index}}"> - <td class="{{selection.bb}}">{{selection.bb}}.{{elt_index}}</td> + <tr id="{{selection.bb}}.{{elt_index+1}}"> + <td class="{{selection.bb}}">{{selection.bb}}.{{elt_index+1}}</td> <td>{{elt}}</td> </tr> </template>
Index: clang/lib/Analysis/FlowSensitive/HTMLLogger.html =================================================================== --- clang/lib/Analysis/FlowSensitive/HTMLLogger.html +++ clang/lib/Analysis/FlowSensitive/HTMLLogger.html @@ -35,9 +35,15 @@ </template> </div> <table id="bb-elements"> +<template> + <tr id="{{selection.bb}}.0"> + <td class="{{selection.bb}}">{{selection.bb}}.0</td> + <td>(initial state)</td> + </tr> +</template> <template data-for="elt in cfg[selection.bb].elements"> - <tr id="{{selection.bb}}.{{elt_index}}"> - <td class="{{selection.bb}}">{{selection.bb}}.{{elt_index}}</td> + <tr id="{{selection.bb}}.{{elt_index+1}}"> + <td class="{{selection.bb}}">{{selection.bb}}.{{elt_index+1}}</td> <td>{{elt}}</td> </tr> </template>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits