Manna added inline comments.

================
Comment at: clang/lib/Sema/SemaLookup.cpp:4662
 
-  for (auto KNPair : KnownNamespaces)
+  for (const auto &KNPair : KnownNamespaces)
     Namespaces.addNameSpecifier(KNPair.first);
----------------
tahonermann wrote:
> The element type is a pair of `NamespaceDecl *` and `bool`. I would skip this 
> change.
Thanks @tahonermann for the explanation. Removed 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149074/new/

https://reviews.llvm.org/D149074

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to