sgraenitz added inline comments.

================
Comment at: clang/test/Interpreter/dynamic-library.cpp:12
+//   return 5;
+// }
 
----------------
Should we wrap this in a `extern "C"` block? Otherwise, the shared library has 
a C++ interface, which is not stable. It won't matter in this simple case, but 
the test might become a pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148992/new/

https://reviews.llvm.org/D148992

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to