tejohnson added a comment.

This was refactored out of patch 3 (the applyImport stuff that I refactored 
into patch 4 in D149117 <https://reviews.llvm.org/D149117>). Previously I was 
controlling this behavior via the MemProfContextDisambiguation pass itself, but 
in refactoring I realized that it is much cleaner and more sensible to be 
controlling it separately via LTO. I also realized it wasn't being tested, so 
added some new tests here.



================
Comment at: llvm/test/ThinLTO/X86/memprof-basic.ll:80
 
-;; Try again but with distributed ThinLTO
-; RUN: llvm-lto2 run %t.o -enable-memprof-context-disambiguation \
----------------
Ignore this and similar differences, need to rebase this on top of my more 
recent version of D149117 that removed these duplicate invocations of test RUN 
lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149215/new/

https://reviews.llvm.org/D149215

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to