craig.topper requested changes to this revision.
craig.topper added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:853
 Error RISCVISAInfo::checkDependency() {
+  bool HasC = Exts.count("c") != 0;
   bool HasD = Exts.count("d") != 0;
----------------
This variable is unused.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:913
 
+  if (HasZcmt && (HasD || HasZcd))
+    return createStringError(
----------------
It wouldn't be incompatible with Zca + D without Zcd would it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133863/new/

https://reviews.llvm.org/D133863

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to