sammccall added inline comments.

================
Comment at: clang/lib/Basic/IdentifierTable.cpp:852
 
+llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, NullabilityKind NK) {
+  switch (NK) {
----------------
IdentifierTable.cpp is a weird place to implement this function (I put it next 
to getNullabilitySpelling).
Happy to move to a different file, or add a new file, if you think either is 
significantly better.

Similarly, happy to add a test for this if it's worth having a unittest with 
only this (obviously nothing else in Specifiers is tested)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149650/new/

https://reviews.llvm.org/D149650

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to