aaron.ballman added a comment. In D146764#4310655 <https://reviews.llvm.org/D146764#4310655>, @aeubanks wrote:
> In D146764#4310398 <https://reviews.llvm.org/D146764#4310398>, @aaron.ballman > wrote: > >> I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, >> so serialization through modules or PCH won't work without that. > > done. how would this sort of change be tested? Thanks! Typically with a test using modules or PCH, so something along these lines: https://github.com/llvm/llvm-project/blob/main/clang/test/Modules/cxx20-10-5-ex1.cpp and/or https://github.com/llvm/llvm-project/blob/main/clang/test/PCH/cxx-namespaces.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
