aeubanks added inline comments.
================
Comment at: llvm/include/llvm/IR/DiagnosticInfo.h:1122
}
+ void
+ getInliningDecisions(SmallVectorImpl<std::string> &InliningDecisions) const;
----------------
can this return a SmallVector instead of taking one as a mutable param?
================
Comment at: llvm/lib/IR/DiagnosticInfo.cpp:462
+ const MDOperand &MO = MDN->getOperand(0);
+ if (auto *MDT = dyn_cast<MDTuple>(MO)) {
+ for (const MDOperand &MO : MDT->operands()) {
----------------
seems simpler if this is always a `MDTuple` instead of special casing one entry
to be `MDString`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141451/new/
https://reviews.llvm.org/D141451
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
