aaron.ballman added inline comments.
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594 + if (DiscardResult) + return true; + ---------------- For my own understanding -- why do we not need to call `discard()` on the operand expression? ================ Comment at: clang/test/AST/Interp/literals.cpp:207-208 + } + /// FIXME: This is rejected because the parameter so sizeof() is not constant. + /// produce a proper diagnostic. + static_assert(IgnoredRejected() == 0, ""); // expected-error {{not an integral constant expression}} \ ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149965/new/ https://reviews.llvm.org/D149965 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits