alexshap added a comment.

@aaron.ballman
Thanks, yeah, there is an issue. Also there are inline-comments by @bcraig and 
@compnerd about the tests.
I used clang-rename, include-fixer, clang-tidy as examples.

alexshap-mbp:extra alexshap$ grep -r -n "sed -e " ./* | head -n 5

./test/clang-tidy/modernize-pass-by-value-multi-fixes.cpp:2:// RUN: sed -e 
's#//.*$##' %s > %t.cpp
./test/include-fixer/exit_on_fatal.cpp:1:// RUN: sed -e 's#//.*$##' %s > %t.cpp
./test/include-fixer/fixeddb.cpp:1:// RUN: sed -e 's#//.*$##' %s > %t.cpp
./test/include-fixer/multiple_fixes.cpp:2:// RUN: sed -e 's#//.*$##' %s > %t.cpp
./test/include-fixer/prefix_variable.cpp:1:// RUN: sed -e 's#//.*$##' %s > 
%t.cpp

alexshap-mbp:test alexshap$ grep -r -n "sed " ./*  | grep rename | head -n 5

./clang-rename/ClassAsTemplateArgument.cpp:16:// RUN: clang-rename -offset=7 
-new-name=Bar %s -- | sed 's,//.*,,' | FileCheck %s
./clang-rename/ClassAsTemplateArgument.cpp:18:// RUN: clang-rename -offset=215 
-new-name=Bar %s -- | sed 's,//.*,,' | FileCheck %s
./clang-rename/ClassFindByName.cpp:10:// RUN: clang-rename rename-all 
-old-name=Foo -new-name=Bar %s -- | sed 's,//.*,,' | FileCheck %s
./clang-rename/ClassReplacements.cpp:6:// RUN: sed 's,//.*,,' %t.cpp | 
FileCheck %s
./clang-rename/ClassSimpleRenaming.cpp:9:// RUN: clang-rename -offset=6 
-new-name=Bar %s -- | sed 's,//.*,,' | FileCheck %s


Repository:
  rL LLVM

https://reviews.llvm.org/D23279



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to