cebowleratibm added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2207 + addUsedOrCompilerUsedGlobal(GV); + else if (CodeGenOpts.KeepStaticConsts && VD->getType().isConstQualified()) + addUsedOrCompilerUsedGlobal(GV); ---------------- why not fold the `if` and `else if` together given that they perform the same action. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3096 + return true; + else if (CodeGenOpts.KeepStaticConsts && VD->getType().isConstQualified()) + return true; ---------------- Fold to a single return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
