rsundahl added a comment. In D143675#4310903 <https://reviews.llvm.org/D143675#4310903>, @eugenis wrote:
> I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's > not even link anywhere in the current version. Right, we should be using it... We will add a test that compiles and links to it as affirmation that we have covered all of the entrypoints that ASan generates. It's also the case that asan_abi_shim.h is redundant since asan_abi_shim.cpp now gets its declarations from ../asan/asan_interface_internal.h which is of course the source of truth for what the shim should be implementing. We will remove that as well and update. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
