benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land.
With my naming comment addressed, LGTM ================ Comment at: clang/include/clang/Lex/PreprocessorOptions.h:73 + /// Perform extra checks for relocatable modules when loading PCM files. + bool RelocatableModules = true; + ---------------- Suggestion: `CheckRelocatableModules`. The current name sounds like a compiler feature rather than controlling diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150320/new/ https://reviews.llvm.org/D150320 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
