MaskRay added a comment.

This seems fine, but please consider making `MC/SubtargetFeature.h` a 
forwarding header temporarily.

Our official build system CMake doesn't do layering checking for headers 
(https://llvm.org/docs/CodingStandards.html#library-layering).

Our unofficial build system Bazel supports layering checking 
<http://maskray.me/blog/2022-09-25-layering-check-with-clang>. You may edit 
`utils/bazel/llvm-project-overlay/llvm/BUILD.bazel` and see whether bazel 
reports a circular dependency. I think this patch is fine, but just in case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150549/new/

https://reviews.llvm.org/D150549

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to