rupprecht added a comment.

In D150226#4338264 <https://reviews.llvm.org/D150226#4338264>, @shafik wrote:

> In D150226#4336755 <https://reviews.llvm.org/D150226#4336755>, @rupprecht 
> wrote:
>
>> We're still using `-Wno-enum-constexpr-conversion`, although I'm not sure if 
>> we need that or if we just forgot to remove it after doing some cleanup. I'm 
>> trying it out now. (Sorry, I'm not sure we were aware that having a way to 
>> turn this off was just temporary).
>
> Please let me know how things look on your end.

It's not that bad, and all remaining breakages have fixes sent out now, but 
still waiting to land. A week or two is probably good enough for us. But I 
don't know about the rest of OSS mentioned in other comments.

(FYI, I'll be out for a few weeks, and I might not have a chance to follow up 
before then)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150226/new/

https://reviews.llvm.org/D150226

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to