john.brawn added a comment.

In D150966#4356779 <https://reviews.llvm.org/D150966#4356779>, @barannikov88 
wrote:

>   Check that the predefined macros don't contain anything that causes a 
> warning
>
> What is 'anything', exactly? Does it include duplicate predefined macros, or 
> it tests something else?
> Sorry for the silly question.

D144654 <https://reviews.llvm.org/D144654> caused a failure 
http://45.33.8.238/macm1/60903/step_7.txt that caused it to be reverted. The 
failure was in tests that use -Wsystem-headers and was because the host that 
clang was built on (aarch64 macos) had duplicate predefines and those tests 
don't specify a target and so the default (i.e. host) target is used. This test 
is mainly so that we have a test that uses -Wsystem-headers that doesn't depend 
on the host machine so that I know D144654 <https://reviews.llvm.org/D144654> 
won't cause further problems when I re-commit it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150966/new/

https://reviews.llvm.org/D150966

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to