jhuber6 added a comment.

In D151098#4360750 <https://reviews.llvm.org/D151098#4360750>, @aaron.ballman 
wrote:

> LGTM, though it's a bit jarring that `-march` suggests using `-mcpu=help` 
> (should we ensure that `-march=help` works on all targets instead?)

Using `-march=help` works inadvertently because it will list the targets when 
given an invalid one. We could probably map the `-mcpu=help` handling to 
`-march=help` but I'm not entirely sure what the semantics should be there. The 
distinction between `-march` and `-mcpu` is still not entirely clear to me, 
it's just a matter of whether or not the target decided to choose one or the 
other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151098/new/

https://reviews.llvm.org/D151098

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to