aaron.ballman added a comment. Thank you for the additional test coverage! The changes LGTM modulo the suggestion from @fhahn on how to improve the comments. (Note, given your goal of verifying that operations work, you might want to consider adding similar coverage for CodeGen tests to verify that we emit sensible LLVM IR for each of these operations as well, if we don't already have sufficient coverage for it.)
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://reviews.llvm.org/D151061 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
