shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/test/SemaCXX/warn-shadow.cpp:33
 void foo() {
   int i; // expected-warning {{declaration shadows a variable in namespace 
'(anonymous)'}}
   int j; // expected-warning {{declaration shadows a variable in namespace 
'one::two'}}
----------------
Note. it looks like gcc does not warn on shadowing for anonymous namespaces. I 
think it makes sense to warn in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151214/new/

https://reviews.llvm.org/D151214

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D151214: [clang][S... Shafik Yaghmour via Phabricator via cfe-commits

Reply via email to