rsandifo-arm marked an inline comment as done.
rsandifo-arm added a comment.

In D148700#4364229 <https://reviews.llvm.org/D148700#4364229>, @aaron.ballman 
wrote:

> This basically LGTM, but we should add documentation to the internals manual 
> too: https://clang.llvm.org/docs/InternalsManual.html#spellings

Oops, hadn't seen that documentation.  Added in the updated patch, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148700/new/

https://reviews.llvm.org/D148700

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to