stuij added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:194
+      NoMovt = false;
+    assert(hasV6MOps() && "Cannot generate execute-only code for this target");
   }
----------------
tschuett wrote:
> What happens in release mode? At the top you now claim that ARMV6M is 
> supported. Could hasV6MOps() silently return false?
This should really be caught by the frontend, but yes, I'm not sure why we use 
assert so often in this kind of code instead of unreachable. Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149444/new/

https://reviews.llvm.org/D149444

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to