barannikov88 added a comment.

In D151047#4369742 <https://reviews.llvm.org/D151047#4369742>, @Sedeniono wrote:

> To create a new fix, do I understand the guide 
> <https://llvm.org/docs/Phabricator.html#using-patch-summaries> correctly that 
> I basically execute `arc diff --verbatim` and mention `Depends on D151047` 
> somewhere in the message? Will it then appear here automatically and reopen 
> the review?

If you want to create a new review, use `arc diff --create`. It will always 
create a new review and assign it a different number.

If you want to reopen review because the patch was reverted:

- cherry-pick the reverted commit;
- do any necessary adjustments for the tests to pass, amend them;
- If you're using arc, use `arc diff --update D151047` as usual. It will update 
the current review, preserving its number.

(The --update option is not necessary if the commit message contains URL to 
this review, but it prevents you from accidentally creating a new review.)

I don't remember if the above steps will change the review status to Reopened.
If that doesn't happen, you can reopen the review manually from the menu below 
(Add Action... -> Reopen Revision).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151047/new/

https://reviews.llvm.org/D151047

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to