domada added inline comments.
================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063 + } +} + ---------------- jdoerfert wrote: > jdoerfert wrote: > > Style `F` > Why does this belong here? We should do it like clang, one function at a > time, or in a generic place. This is not OpenMP specific at all. Hi Johannes, thank you very much for your feedback. I would like to explain my idea why I add this function to OMPIRBuilder: Current situation: 1) MLIR does not support LLVM IR function attributes for production quality code. MLIR function passthrough attributes should be used only for PoC work ( https://mlir.llvm.org/docs/Dialects/LLVM/#attribute-pass-through ) 2) OpenMP MLIR operations can be translated into multiple LLVM IR functions. My idea was to add functionality of inserting function attributes after the end of OpenMP MLIR code translation. OMPIRBuilder has necessary knowledge about generated LLVM IR. That's why I decided to do it here and to focus mainly on the code generated for OpenMP pragmas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147321/new/ https://reviews.llvm.org/D147321 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
