Mogball accepted this revision. Mogball added inline comments. This revision is now accepted and ready to land.
================ Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:878 }]; - let arguments = (ins StrAttr:$intrin, Variadic<LLVM_Type>:$args); + let arguments = (ins StrAttr:$intrin, Variadic<LLVM_Type>:$args, DefaultValuedAttr<LLVM_FastmathFlagsAttr, "{}">:$fastmathFlags); let results = (outs Variadic<LLVM_Type>:$results); ---------------- here as well please ================ Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:883 }]; let assemblyFormat = [{ + $intrin `(` $args `)` `:` functional-type($args, $results) custom<LLVMOpAttrs>(attr-dict) ---------------- and this one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits