Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

[Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL279838: Don't diagnose non-modular includes when we are not 
compiling a module. (authored by mren).

Changed prior to commit:
  https://reviews.llvm.org/D23858?vs=69183&id=69397#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D23858

Files:
  cfe/trunk/lib/Lex/ModuleMap.cpp
  cfe/trunk/test/VFS/Inputs/Nonmodular/A.h
  cfe/trunk/test/VFS/Inputs/Nonmodular/Nonmodular.modulemap
  cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml
  cfe/trunk/test/VFS/Inputs/Nonmodular/test.c
  cfe/trunk/test/VFS/Inputs/Nonmodular/umbrella.h
  cfe/trunk/test/VFS/test_nonmodular.c


Index: cfe/trunk/lib/Lex/ModuleMap.cpp
===================================================================
--- cfe/trunk/lib/Lex/ModuleMap.cpp
+++ cfe/trunk/lib/Lex/ModuleMap.cpp
@@ -297,7 +297,9 @@
   if (LangOpts.ModulesStrictDeclUse) {
     Diags.Report(FilenameLoc, diag::err_undeclared_use_of_module)
         << RequestingModule->getFullModuleName() << Filename;
-  } else if (RequestingModule && RequestingModuleIsModuleInterface) {
+  } else if (RequestingModule && RequestingModuleIsModuleInterface &&
+             LangOpts.isCompilingModule()) {
+    // Do not diagnose when we are not compiling a module. 
     diag::kind DiagID = RequestingModule->getTopLevelModule()->IsFramework ?
         diag::warn_non_modular_include_in_framework_module :
         diag::warn_non_modular_include_in_module;
Index: cfe/trunk/test/VFS/Inputs/Nonmodular/umbrella.h
===================================================================
--- cfe/trunk/test/VFS/Inputs/Nonmodular/umbrella.h
+++ cfe/trunk/test/VFS/Inputs/Nonmodular/umbrella.h
@@ -0,0 +1,5 @@
+#ifndef __umbrella_h__
+#define __umbrella_h__
+
+#include <Nonmodular/A.h>
+#endif
Index: cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml
===================================================================
--- cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml
+++ cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml
@@ -0,0 +1,34 @@
+{
+  'version': 0,
+  'case-sensitive': 'false',
+  'ignore-non-existent-contents': 'true',
+  'roots': [
+    {
+      'type': 'directory',
+      'name': "VDIR/Nonmodular.framework/Headers",
+      'contents': [
+        {
+          'type': 'file',
+          'name': "umbrella.h",
+          'external-contents': "IN_DIR/Inputs/Nonmodular/umbrella.h"
+        },
+        {
+          'type': 'file',
+          'name': "A.h",
+          'external-contents': "IN_DIR/Inputs/Nonmodular/A.h"
+        }
+      ]
+    },
+    {
+      'type': 'directory',
+      'name': "VDIR/Nonmodular.framework/Modules",
+      'contents': [
+        {
+          'type': 'file',
+          'name': "module.modulemap",
+          'external-contents': "OUT_DIR/module.modulemap"
+        }
+      ]
+    }
+  ]
+}
Index: cfe/trunk/test/VFS/Inputs/Nonmodular/A.h
===================================================================
--- cfe/trunk/test/VFS/Inputs/Nonmodular/A.h
+++ cfe/trunk/test/VFS/Inputs/Nonmodular/A.h
@@ -0,0 +1 @@
+// A.h
Index: cfe/trunk/test/VFS/Inputs/Nonmodular/test.c
===================================================================
--- cfe/trunk/test/VFS/Inputs/Nonmodular/test.c
+++ cfe/trunk/test/VFS/Inputs/Nonmodular/test.c
@@ -0,0 +1,3 @@
+// expected-no-diagnostics
+
+#include "umbrella.h"
Index: cfe/trunk/test/VFS/Inputs/Nonmodular/Nonmodular.modulemap
===================================================================
--- cfe/trunk/test/VFS/Inputs/Nonmodular/Nonmodular.modulemap
+++ cfe/trunk/test/VFS/Inputs/Nonmodular/Nonmodular.modulemap
@@ -0,0 +1,5 @@
+framework module Nonmodular [extern_c] {
+  umbrella header "umbrella.h"
+  export *
+  module * { export * }
+}
Index: cfe/trunk/test/VFS/test_nonmodular.c
===================================================================
--- cfe/trunk/test/VFS/test_nonmodular.c
+++ cfe/trunk/test/VFS/test_nonmodular.c
@@ -0,0 +1,11 @@
+// REQUIRES: shell
+
+// RUN: rm -rf %t
+// RUN: mkdir -p %t/vdir %t/cache %t/outdir
+// We can't have module.map inside Inputs/Nonmodular.
+// RUN: cp %S/Inputs/Nonmodular/Nonmodular.modulemap %t/outdir/module.modulemap
+//
+// RUN: sed -e "s:VDIR:%t/vdir:g" -e "s:IN_DIR:%S:g" -e "s:OUT_DIR:%t/outdir:g" %S/Inputs/Nonmodular/nonmodular-headers.yaml > %t/vdir/nonmodular-headers.yaml
+// RUN: %clang_cc1 -fmodule-name=Nonmodular -fmodules -Wnon-modular-include-in-framework-module -verify -fimplicit-module-maps -fmodules-cache-path=%t/cache -ivfsoverlay %t/vdir/nonmodular-headers.yaml -I %S/Inputs -F %t/vdir -fsyntax-only %S/Inputs/Nonmodular/test.c
+
+// expected-no-diagnostics

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits