erichkeane added a comment. In D152195#4399445 <https://reviews.llvm.org/D152195#4399445>, @eandrews wrote:
> In D152195#4399251 <https://reviews.llvm.org/D152195#4399251>, @erichkeane > wrote: > >> I think the patch looks fine, but this needs a release note. > > Just so I know - Does every bug fix need a release note now? Just about every commit we expect to have a release note unless it is fixing a regression introduced since the last release, or is NFC. So yes, every bug fix should have one. If possible, add a link to the github issue (if it doesn't exist, obviously you don't have to). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152195/new/ https://reviews.llvm.org/D152195 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
