ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land.
LGTM. And please wait for several days for other reviewers. ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:132-136 if constexpr (ThrowInUnhandledException) { throw 1; + } else if constexpr (RethrowInUnhandledException) { + throw; } ---------------- denizevrenci wrote: > ChuanqiXu wrote: > > I don't know clang-tidy a lot. But is these two branches different in > > clang-tidy really? > Yes, rethrows are handled differently than throw expressions with arguments. > You can find the relevant implementation in ExceptionAnalyzer.cpp:[462:475]. OK, sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152330/new/ https://reviews.llvm.org/D152330 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits