arsenm added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387
+ } else {
+ auto IntTy = dyn_cast<IntegerType>(Args[i]->getType());
+ if (IntTy && IntTy->getBitWidth() == 32)
+ WhatToStore.push_back(
----------------
vikramRH wrote:
> arsenm wrote:
> > isIntegerTy(32).
> >
> > I also do not understand why only 32-bit integers would be promoted to
> > 64-bit (or why this would be zext). This doesn't match varargs ABI
> > handling, where everything smaller would be promoted to i32.
> Right, But default promotions would have happened already, this additional
> promotion is due to runtime processing requirement
Is this documented somewhere? If it's promote everything to i64, I'd prefer to
handle all types rather than special casing 32
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150427/new/
https://reviews.llvm.org/D150427
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
