Sedeniono marked an inline comment as done. Sedeniono added inline comments.
================ Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170 /// The indent in characters for each level. + /// It remembers the indent of previous lines (that are not PP directives) of + /// equal or lower levels. This is used to align formatted lines to the indent ---------------- barannikov88 wrote: > Sedeniono wrote: > > Sedeniono wrote: > > > HazardyKnusperkeks wrote: > > > > And then reformat the comment. > > > Done. > > Mh, it says [that it couldn't apply the > > patch](https://reviews.llvm.org/harbormaster/build/367648/). I uploaded a > > patch containing as only change the reformatted comment, via the Web UI > > ("Update Diff" at the top right corner). Should I have uploaded a > > "squashed" diff, containing also ALL changes that I made before (the > > `resize` etc)? In other words, is Phabricator expecting individual patches > > and it merges and accumulates them itself? Or does each new uploaded patch > > overwrite all previous patches? > The latter Ok, it took me 2 tries, but it seems that I managed to upload the full list of changes via `arc diff` now. I had to specify the origin commit explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
