Author: OCHyams Date: 2023-06-13T12:43:46+01:00 New Revision: de6da6ad55d3ca945195d1cb109cb8efdf40a52a
URL: https://github.com/llvm/llvm-project/commit/de6da6ad55d3ca945195d1cb109cb8efdf40a52a DIFF: https://github.com/llvm/llvm-project/commit/de6da6ad55d3ca945195d1cb109cb8efdf40a52a.diff LOG: Reapply D146987 "[Assignment Tracking] Enable by default" See https://discourse.llvm.org/t/rfc-enable-assignment-tracking/69399 This sets the -Xclang -fexperimental-assignment-tracking flag to the value enabled which means it will be enabled so long as none of the following are true: it's an LTO build, LLDB debugger tuning has been specified, or it's an O0 build (no work is done in any case if -g is not specified or -gmlt is used). This reverts commit 9e7f14a8211c82dca64bd6b22d1c450d4c6d3e5b which reverts https://reviews.llvm.org/D146987 Added: Modified: clang/include/clang/Driver/Options.td clang/test/CodeGen/assignment-tracking/flag.cpp Removed: ################################################################################ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index e2cc71bd869a9..8f5db34551c07 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -5937,7 +5937,7 @@ def fexperimental_assignment_tracking_EQ : Joined<["-"], "fexperimental-assignme Group<f_Group>, CodeGenOpts<"EnableAssignmentTracking">, NormalizedValuesScope<"CodeGenOptions::AssignmentTrackingOpts">, Values<"disabled,enabled,forced">, NormalizedValues<["Disabled","Enabled","Forced"]>, - MarshallingInfoEnum<CodeGenOpts<"AssignmentTrackingMode">, "Disabled">; + MarshallingInfoEnum<CodeGenOpts<"AssignmentTrackingMode">, "Enabled">; } // let Flags = [CC1Option, NoDriverOption] diff --git a/clang/test/CodeGen/assignment-tracking/flag.cpp b/clang/test/CodeGen/assignment-tracking/flag.cpp index aa1f054dae4d7..3bd974fe07c6c 100644 --- a/clang/test/CodeGen/assignment-tracking/flag.cpp +++ b/clang/test/CodeGen/assignment-tracking/flag.cpp @@ -8,10 +8,10 @@ // RUN: -emit-llvm %s -o - -fexperimental-assignment-tracking=disabled -O1\ // RUN: | FileCheck %s --check-prefixes=DISABLE -//// Disabled by default: +//// Enabled by default: // RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone \ // RUN: -emit-llvm %s -o - -O1 \ -// RUN: | FileCheck %s --check-prefixes=DISABLE +// RUN: | FileCheck %s --check-prefixes=ENABLE //// Disabled at O0 unless forced. // RUN: %clang_cc1 -triple x86_64-none-linux-gnu -debug-info-kind=standalone \ _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits