goldstein.w.n added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:597
+ // callsite violating the constraint.
+ if (checkCallerDoesNotAccessMemory() && !CB->doesNotAccessMemory()) {
+ // Wait until we know we actually need it to do potentially expensive
----------------
nikic wrote:
> For these you generally want to query `getMemoryEffects()` on the
> caller/callee once and then work on that representation, instead of doing
> separate queries for everything. This may allow more precise handling and
> likely reduces the compile-time impact, as doing these attribute lookups is
> quite expensive.
Re-running compile time checks, will post revised numbers tomorrow.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152226/new/
https://reviews.llvm.org/D152226
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
