[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

[Piotr Zegar via Phabricator via cfe-commits]

PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.

Overall looks fine.



================
Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:545-547
+    if (isa<DecompositionDecl>(AliasDecl->getSingleDecl())) {
+      const auto *AliasDecompositionDecl =
+          cast<DecompositionDecl>(AliasDecl->getSingleDecl());
----------------
this could be merged, try dyn_cast


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152852/new/

https://reviews.llvm.org/D152852

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits