shchenz added a comment. @qiongsiwu1 Hi, thanks for the patch. Almost good to me, except one small nit.
================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 + CmdArgs.push_back(Args.MakeArgString( + Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { ---------------- Seems other options leverage the default value in the back end, for example the default value for `DisableIntegratedAS` in backend is false, so when the front end requires integrated-as, maybe we can save the option here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits