nikic added a comment.
Looks reasonable. Main note I have is that I think the use of getUnqual() over
passing AddrSpace=0 would be preferred.
================
Comment at: clang/lib/CodeGen/CGAtomic.cpp:91
auto Addr = CGF.Builder.CreatePointerBitCastOrAddrSpaceCast(
- VoidPtrAddr, IntTy->getPointerTo(), "atomic_bitfield_base");
+ VoidPtrAddr, llvm::PointerType::get(CGF.getLLVMContext(), 0),
+ "atomic_bitfield_base");
----------------
getUnqual
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2045
if (IsIndirect)
- LLTy = LLTy->getPointerTo(0);
+ LLTy = llvm::PointerType::get(getVMContext(), 0);
FrameFields.push_back(LLTy);
----------------
getLLVMContext?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152321/new/
https://reviews.llvm.org/D152321
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
