yaxunl added inline comments.
================
Comment at: clang/test/Driver/linker-wrapper.c:48
+// AMDGPU-LINK-ID: clang{{.*}} -o {{.*}}.img --target=amdgcn-amd-amdhsa
-mcpu=gfx90a -O2 -Wl,--no-undefined {{.*}}.o {{.*}}.o
+
// RUN: clang-offload-packager -o %t.out \
----------------
can we put some variables in the input bitcode so that we can check the linked
bitcode?
I would expect there will be only one linked bitcode for gfx90a:xnack+ and it
contains both variables.
I don't think it is a good idea to let the final object embed bitcode for both
gfx90a:xnack+ and gfx90a since that will result in an invalid container.
Therefore I think we should only do linking with target ID's from the first
container.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152882/new/
https://reviews.llvm.org/D152882
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
