schittir added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed() || - lstate->isUnlockedAndPossiblyDestroyed()); + assert(lstate && (lstate->isUntouchedAndPossiblyDestroyed() || + lstate->isUnlockedAndPossiblyDestroyed())); ---------------- steakhal wrote: > Wouldn't it be better to do an with a comment, like below? ``` assert(lstate && "lstate should not be null"); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152977/new/ https://reviews.llvm.org/D152977 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
