abel-bernabeu added a comment.

In D153008#4428568 <https://reviews.llvm.org/D153008#4428568>, @MaskRay wrote:

> This new update still applies many unneeded `getParser().Lex();` and adds a 
> test at a wrong layer 
> <https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer>
>  (clang/test/CodeGen):

Would you rather have:

- LLVM IR as input
- assembly as output
- the test placed under llvm/test/CodeGen/RISCV/

?

That would make the test for verbose, but it would make the test simple. Please 
confirm your preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to