akhuang added inline comments.

================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1470
+                                ->getLambdaStaticInvoker()) &&
+             !Fn->getName().contains("__impl")) {
+    // If emitting a lambda with static invoker on X86 Windows, change
----------------
efriedma wrote:
> I'm not sure `__impl` is unique enough that user code will never use it.  (I 
> mean, it's reserved, but we don't actually forbid using it.)
> 
> Can we use the isDelegateCall() bit?
yep, that makes more sense. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137872/new/

https://reviews.llvm.org/D137872

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to