mikecrowe added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:202 +/// Called for each format specifier by ParsePrintfString. +bool FormatStringConverter::HandlePrintfSpecifier( + const analyze_printf::PrintfSpecifier &FS, const char *StartSpecifier, ---------------- mikecrowe wrote: > PiotrZSL wrote: > > this function should be split into smaller one. > I agree. I'm surprised it hasn't come up in review earlier. I tried to do so > prior to pushing the very first version of this for review and gave up since > the parts ended up referring to so many local variables making the code even > harder to understand than it is now. I will have another attempt. It turns out that things are working out much better in my second attempt at splitting this function. I shall address the other new review comments before sending another revision for review though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149280/new/ https://reviews.llvm.org/D149280 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
