rogfer01 added a comment.

Thanks @eopXD. Not sure why you didn't observe the failure. I understand your 
build has `-DLLVM_ENABLE_ASSERTIONS=ON`.

I investigated a bit the libcxx errors flagged by the precommit CI. I can get 
similar (but not exactly the same errors) if the build before this change is 
`-DLLVM_ENABLE_PROJECTS=clang -DLLVM_ENABLE_RUNTIMES=libcxx`, then I apply this 
change and then I run libcxx tests: several precompiled headers become stale 
after this change and would need to be rebuilt. Starting from a clean build 
directory avoids this issue.

I want to do a few more checks locally before committing. Sorry for the delay.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153111/new/

https://reviews.llvm.org/D153111

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to