cor3ntin added inline comments.

================
Comment at: clang/test/Lexer/unicode.c:30
 
-        int _;
+int a;
 
----------------
tbaeder wrote:
> Are these changes only for the case where we compile as c++? I know lots of C 
> (and c++?) projects use `_` as GNU gettext identifier to mark a translatable 
> string.
> Are these changes only for the case where we compile as c++
Yes

>  I know lots of C (and c++?) projects use _ as GNU gettext identifier to mark 
> a translatable string.

That's doesn't interfere with this feature. if `_` is defined as a macro, it's 
simply not possible to declare a variable of that name,  let alone more than 
one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153536/new/

https://reviews.llvm.org/D153536

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to