balazske added inline comments.
================
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1325
if (!Pred)
- break;
+ continue;
}
----------------
steakhal wrote:
> Why do you continue here? Do you have a case for this?
This is only because the same loop has other failure places (if the state can
not be applied) where `continue` is used already. The reason is that if one
`addTransition` fails a next one may succeed. It is probably better to use
`break` at all places. Even then what was already added to the state can not be
removed, so it may be not wrong to add all states that can be added.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153776/new/
https://reviews.llvm.org/D153776
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
