hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:137
Dict.handle("ClangTidy", [&](Node &N) { parse(F.ClangTidy, N); });
- Dict.handle("AllowStalePreamble", [&](Node &N) {
- F.AllowStalePreamble = boolValue(N, "AllowStalePreamble");
----------------
I wonder whether it is worth keeping this flag, but no-op (just emitting an
warning message, this flag is no-op).
Probably not worth, since this flag was introduced recently, and it is not in
any release.
================
Comment at: clang-tools-extra/clangd/ParsedAST.h:157
std::vector<PragmaMark> Marks;
// Data, stored after parsing. std::nullopt if AST was built with a stale
// preamble.
----------------
nit: update the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153882/new/
https://reviews.llvm.org/D153882
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
