ymandel marked 4 inline comments as done.
ymandel added a comment.
Rebased, thanks!
================
Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:73
+
+ // Whether this node is the head of a feedback edge within the interval.
+ bool IsFeedbackHead = false;
----------------
xazax.hun wrote:
> Is feedback edge a special terminology? I think we might simply call these
> back edges most of the time.
That's the language from the paper but I prefer standard "back edge"
terminology so updated to reflect.
================
Comment at: clang/lib/Analysis/IntervalPartition.cpp:23-25
+namespace {
+template <typename Node> using NodeData = CFGInterval::NodeData<Node>;
+} // namespace
----------------
xazax.hun wrote:
> What is the reason for putting a using statement in an anonymous namespace?
I... don't remember what I was thinking. Regardless, seems pointless for a
template -- fixed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153058/new/
https://reviews.llvm.org/D153058
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
