yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164
+ StringRef ArgVal = Arg->getValue(1);
+ if (ArgVal.startswith("-mllvm=")) {
+ ArgVal = ArgVal.substr(strlen("-mllvm="));
----------------
jhuber6 wrote:
> arsenm wrote:
> > StringRef Prefix("-mllvm=") and then use the length instead of strlen
> You could probably also do `ArgVal.split("-mllvm=").second` and push back
> first or second depending on whether or not `second` is empty.
will use ArgVal.split
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154145/new/
https://reviews.llvm.org/D154145
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
