JOE1994 added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); - Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCall(F, Buf.getPointer())); ---------------- barannikov88 wrote: > jrtc27 wrote: > > Missed `Buf = Buf.withElementType(Int8Ty);`? According to the comment > > above, Buf is a `void **` not a `void *`/`char *`. > It would be a dead code because only the pointer is used down below. > ElementType associated with `Buf` is never referenced, so I intentionally omitted `Buf = Buf.withElementType(Int8Ty);`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154285/new/ https://reviews.llvm.org/D154285 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits